GameState.run_seed defaults to 123, silently producing identical worlds #1

New issue

Closed

opened 2026-08-15 11:36:18 +01:00 by liamjd · 0 comments

liamjd commented

2026-08-15 11:36:18 +01:00

Owner

scripts/GameState.gd declares:

var run_seed: int = 123

Nothing writes to it yet, so any code that reads GameState.run_seed gets 123 and generates an identical world every run, with no indication that the seed was never set.

The whole terrain and threat-cycle design rests on seeded determinism, so an unset seed silently masquerading as a valid one is the worst failure mode here — it looks like it works.

Make the unset state either loud or honest:

default to 0 and treat that as "not set" (assert or warn at the point of use), or
have GameState randomise in _ready(), so an unset seed is at least genuinely random rather than a fixed constant.

Blocks meaningful testing of world generation.

`scripts/GameState.gd` declares: ```gdscript var run_seed: int = 123 ``` Nothing writes to it yet, so any code that reads `GameState.run_seed` gets `123` and generates an identical world every run, with no indication that the seed was never set. The whole terrain and threat-cycle design rests on seeded determinism, so an unset seed silently masquerading as a valid one is the worst failure mode here — it looks like it works. Make the unset state either loud or honest: - default to `0` and treat that as "not set" (assert or warn at the point of use), or - have `GameState` randomise in `_ready()`, so an unset seed is at least genuinely random rather than a fixed constant. Blocks meaningful testing of world generation.

liamjd referenced this issue from a commit

2026-08-15 11:58:40 +01:00

Randomise run_seed on startup instead of defaulting to 123

liamjd referenced this issue from a pull request that will close it,

2026-08-15 12:00:49 +01:00

Randomise run_seed on startup instead of defaulting to 123 #4

liamjd closed this issue

2026-08-15 12:01:53 +01:00

liamjd referenced this issue from a commit

2026-08-15 12:01:55 +01:00

Randomise run_seed on startup instead of defaulting to 123 (#4)

liamjd referenced this issue from a commit