Connect autoload signals only outside the editor (#149) #150

Merged

liamjd merged 2 commits from 149-game-gd-editor-signals into main

2026-10-10 15:39:15 +01:00

liamjd commented

2026-10-10 15:31:11 +01:00

Owner

Closes #149

Moves the GameState.building_placed / building_removed and GameClock.tick connections in common/game.gd inside the existing if not Engine.is_editor_hint(): guard. game.gd is @tool, and in the editor the autoloads are bare Nodes with no signals. The first connect therefore errored, and stopped _ready(), every time the editor opened game.tscn.

Verification

--headless --editor --quit: no script errors (was 1).
On a live instance of game.tscn, GameState.building_placed, building_removed and GameClock.tick are all still connected to their handlers.
GUT suite: 883 passed, 1 pending (the existing #85 placeholder).

Note

Branched from origin/main and independent of #148. The two touch nearby lines of game.gd, so whichever merges second may need a trivial rebase.

🤖 Generated with Claude Code

Closes #149 Moves the `GameState.building_placed` / `building_removed` and `GameClock.tick` connections in `common/game.gd` inside the existing `if not Engine.is_editor_hint():` guard. `game.gd` is `@tool`, and in the editor the autoloads are bare `Node`s with no signals. The first `connect` therefore errored, and stopped `_ready()`, every time the editor opened `game.tscn`. ## Verification - `--headless --editor --quit`: no script errors (was 1). - On a live instance of `game.tscn`, `GameState.building_placed`, `building_removed` and `GameClock.tick` are all still connected to their handlers. - GUT suite: 883 passed, 1 pending (the existing #85 placeholder). ## Note Branched from `origin/main` and independent of #148. The two touch nearby lines of `game.gd`, so whichever merges second may need a trivial rebase. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

liamjd added 1 commit

2026-10-10 15:31:11 +01:00

Connect autoload signals only outside the editor (#149 ) 57947eb0d5

game.gd is @tool, so _ready() also runs when the editor opens game.tscn. The
GameState/GameClock connections sat outside the is_editor_hint() guard, and in
the editor the autoloads are bare Nodes with no signals, so the first one
errored and aborted _ready(). They are game wiring, so they move inside the
guard.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

liamjd added 1 commit

2026-10-10 15:37:29 +01:00

Merge branch 'main' into 149-game-gd-editor-signals 1771136ebc